Sets up initial gem to patch shoulda-matchers#1
Merged
Conversation
bsimpson
approved these changes
Feb 6, 2020
bsimpson
left a comment
bsimpson
left a comment
There was a problem hiding this comment.
What are the next steps here? Do we need the CI plumbing to publish this to Nexus?
Contributor
Author
|
Yep, next step is adding the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pivotal Story: https://www.pivotaltracker.com/story/show/164603806
Since we're taking advantage of storing UUIDs in MySQL as
binary, the shoulda-matchers has an issue when the UUID ends in anf. This has lead to some flakey tests. We made an effort to fix this upstream, which doesn't appear to be gaining traction. This extracts the fix into a gem so we don't have to support a hard fork for this.